#32958: URLValidator tests don't obviously test how long validation takes ---------------------------------------------+------------------------ Reporter: Chris Jerdonek | Owner: nobody Type: Uncategorized | Status: new Component: Testing framework | Version: dev Severity: Normal | Keywords: Triage Stage: Unreviewed | Has patch: 0 Needs documentation: 0 | Needs tests: 0 Patch needs improvement: 0 | Easy pickings: 0 UI/UX: 0 | ---------------------------------------------+------------------------ I was looking at the validator tests and came across this comment ("Trailing junk does not take forever to reject"): https://github.com/django/django/blob/012f38f9594b35743e9ab231757b7b62db638323/tests/validators/tests.py#L258-L260
However, it's not obvious whether the test actually checks how long the validation takes, or what "forever" really means (e.g. is 1 second forever?). For example, I couldn't see any measurement of elapsed time in the tests. It would be good if the comment elaborated on this and, if necessary, the test could check that validation doesn't take too long. -- Ticket URL: <https://code.djangoproject.com/ticket/32958> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/052.6267b4148cc413ed161e0e9e6051db43%40djangoproject.com.