#32973: Pass generator expression to str.join() instead of list / tuple
throughout
code base
-------------------------------------+-------------------------------------
Reporter: Chris Jerdonek | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Core (Other) | Version: dev
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* status: new => closed
* resolution: => wontfix
* component: Uncategorized => Core (Other)
Comment:
A list comprehension is preferable here as `str.join()` converts to list
internally anyway. It is better performance to provide a list up front.
- https://stackoverflow.com/questions/9060653/list-comprehension-without-
in-python/9061024#9061024
- https://github.com/adamchainz/flake8-comprehensions/issues/156
--
Ticket URL: <https://code.djangoproject.com/ticket/32973#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.9496ccd67b47f2727f88c0eaf42d8d43%40djangoproject.com.
