#32971: System check methods can yield their items instead of creating lists at
every layer
-------------------------------------+-------------------------------------
     Reporter:  Chris Jerdonek       |                    Owner:  nobody
         Type:                       |                   Status:  closed
  Cleanup/optimization               |
    Component:  Core (System         |                  Version:  dev
  checks)                            |
     Severity:  Normal               |               Resolution:  wontfix
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

 Replying to [comment:5 Chris Jerdonek]:
 > You can see the public method calling several internal methods --
 unpacking each of their results to create the new list. Each internal
 layer adds unnecessary list creations.

 True, but I don't think that's a big issue. I'd like to keep internal
 methods consistent with what we have in docs (we recommend creating
 internal `_check...` methods which use this pattern).

-- 
Ticket URL: <https://code.djangoproject.com/ticket/32971#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.07d2907371a023ae768f48ac01674502%40djangoproject.com.

Reply via email to