#32919: Micro-optimisations for lexing & parsing of templates.
-------------------------------------+-------------------------------------
     Reporter:  Keryn Knight         |                    Owner:  Keryn
         Type:                       |  Knight
  Cleanup/optimization               |                   Status:  closed
    Component:  Template system      |                  Version:  dev
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Chris Jerdonek):

 I noticed that some additional, related improvements can be made to
 `Lexer.create_token()`. For example, `in_tag` is currently checked twice,
 when it can be checked once. Also, `token_start` only needs to be defined
 when `in_tag` is true. (Both seen here:
 
https://github.com/django/django/blob/edf184dd067e676962e8e1fc1a50397b810461d6/django/template/base.py#L373-L382
 )

-- 
Ticket URL: <https://code.djangoproject.com/ticket/32919#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d1d42298505e391a57497f8697a7d13d%40djangoproject.com.

Reply via email to