#33074: Do not require fields on UpdateView/CreateView if form specified
-------------------------------------+-------------------------------------
Reporter: Dan Swain | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Generic views | Version: 3.2
Severity: Normal | Resolution: invalid
Keywords: CreateView | Triage Stage:
UpdateView form ModelFormMixin | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* status: new => closed
* resolution: => invalid
Comment:
Thanks for the report, however specifying both `fields` and `form_class`
is not permitted and `fields` are not checked when `form_class` is
specified, see
[https://github.com/django/django/blob/3219dd3388c437b4bd869b76ddd43c9cdad05090/django/views/generic/edit.py#L76-L99
get_form_class()]. I'm not sure how you could reach this path with
`form_class` 🤔
--
Ticket URL: <https://code.djangoproject.com/ticket/33074#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.e601b957099057bf9d09ceab0ddcc3c0%40djangoproject.com.
