#33130: ErrorDict doesn't pass the dict type check in JsonResponse.
---------------------------------+-------------------------------------
     Reporter:  Jaap Roes        |                    Owner:  Jaap Roes
         Type:  Bug              |                   Status:  assigned
    Component:  Forms            |                  Version:  4.0
     Severity:  Release blocker  |               Resolution:
     Keywords:                   |             Triage Stage:  Accepted
    Has patch:  1                |      Needs documentation:  0
  Needs tests:  1                |  Patch needs improvement:  1
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+-------------------------------------

Comment (by Jaap Roes):

 Sadly the fix isn't as simple as initially thought (comment:2). It solves
 the issue with the type check in `JsonResponse` but the actual json
 serialization results in an empty JSON object instead of the intended
 result of a JSON object with field names and error messages.

 I will write additional tests to also check if the `ErrorDict` also
 serializes in the desired way, and come up with a better fix (the PR
 comments already have a good indication to what that may be).

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33130#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.601dc9b9f6ccfb5938afe7cbfe559632%40djangoproject.com.

Reply via email to