#27674: Deprecate GeoModelAdmin and OSMGeoAdmin
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Giannis
Type: | Adamopoulos
Cleanup/optimization | Status: new
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* status: closed => new
* resolution: fixed =>
* needs_tests: 1 => 0
* stage: Ready for checkin => Accepted
Comment:
Replying to [comment:10 Nick Pope]:
> While looking into #33372 I noticed that there are two
`OpenLayersWidget` classes:
>
> - `django.contrib.gis.admin.widgets.OpenLayersWidget` - this is used by
the deprecated `GeoModelAdmin` class and targets OpenLayers 2.x
> - `django.contrib.gis.forms.widgets.OpenLayersWidget` - this is used as
a parent to `OSMWidget` (used by the new `GISModelAdmin`) and targets
OpenLayers 3.x
>
> Deprecation warnings were added for `GeoModelAdmin` and `OSMGeoAdmin` as
part of this ticket but `.admin.widgets.OpenLayersWidget` has no warning.
Do we need to add one?
Agreed, we can deprecate
`django.contrib.gis.admin.widgets.OpenLayersWidget` in Django 4.1 and
remove it in 5.0. Let's reopen.
> Do we also need to warn about `gis/admin/openlayers.html` and
`gis/admin/osm.html` templates going away? (Not sure whether we add a
documentation note?)
As far as I'm concerned, it is not needed.
--
Ticket URL: <https://code.djangoproject.com/ticket/27674#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.c2710df3904735f1ce661ecf88b7798c%40djangoproject.com.
