#33434: Browser font resizing doesn’t work in Django admin due to pixel values
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: ravi
| kunwar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: accessibility, ux, | Triage Stage: Accepted
wcag, admin, css |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Thibaud Colas):
Hi Ravi, yes, to echo what David said above, for now I would have
recommended to make a PR with only what I described under "Proposed fix",
not the four points under "Proposed additional changes".
In my opinion those other recommendations should be covered in separate
PRs, and even before that someone would ideally first make a proposal in a
separate ticket. All of those changes are worthwhile in my opinion, and
could technically all be done at the same time, but keeping them separate
will make them simpler to review and get in sooner rather than later.
----
For point 1. about CSS code style, I would have expected a new page,
following what Django has for
[https://docs.djangoproject.com/en/4.0/internals/contributing/writing-
code/javascript/ JavaScript].
For point 4., I really think someone has to make a ticket with a solid
proposal, backed with research and screenshots, before we jump to a PR.
From what I could see, Django’s base font size for the admin interface is
[https://github.com/django/django/blob/aecfc40c88ce19aa0b830ee2d3d2077b304757bc/django/contrib/admin/static/admin/css/base.css#L67
14px], and there are lots of places where it gets below that. I guess a
reasonable first stab could be to increase the base to 16px (1rem), and
use 14px (0.875rem) for all of the areas currently under 14px.
--
Ticket URL: <https://code.djangoproject.com/ticket/33434#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/070.ee331fc400d4ce9fc51d316cd5695129%40djangoproject.com.
