#33624: Only disable console logging when ADMINS is set
---------------------------------+--------------------------------------
Reporter: Alex Dehnert | Owner: (none)
Type: Uncategorized | Status: closed
Component: Error reporting | Version: 4.0
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by Carlton Gibson):
* status: new => closed
* resolution: => invalid
Comment:
HI Alex.
> ... and ADMINS is non-empty ...
The `mail_admins` function, used by AdminEmailHandler already includes a
check for this:
{{{
def mail_admins(
subject, message, fail_silently=False, connection=None,
html_message=None
):
"""Send a message to the admins, as defined by the ADMINS setting."""
if not settings.ADMINS:
return
}}}
[https://github.com/django/django/blob/0b31e024873681e187b574fe1c4afe5e48aeeecf/django/core/mail/__init__.py#L117-L122
Src]
The `ADMINS` setting is discussed multiple times in the docs, but
explicitly in the
[https://docs.djangoproject.com/en/4.0/howto/deployment/checklist/#admins-
and-managers deployment checklist], and
[https://docs.djangoproject.com/en/4.0/howto/error-reporting/#email-
reports error reporting documentation]. For me, I think that sufficient
really.
--
Ticket URL: <https://code.djangoproject.com/ticket/33624#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018007d2ef7c-dc4d8022-fbfa-42cb-8ca6-5ae016161d23-000000%40eu-central-1.amazonses.com.
