#29799: Allow registration and unregistration of lookups per field instances.
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Can
| Sarıgöl
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson):
Hi Himanshu.
The rough outline looks right. There are various variations but, ''I'd
like to add a custom lookup just for **this** model'' — the model being
the bearer of field instances; ''I'd like to disable **this** lookup on
this model'', and so on.
The specific behaviours are hard to say definitively one way or the other
until we get to the review stage. Looking at test cases, and seeing how
the API looks at that point is much easier to speak clearly to.
(For example, I'm not sure what to say about trying to unregister a non-
registered lookup on a class... — we **could** error, or we could `pass`:
the end effect is that the lookup is not registered on the class... 🤔 —
it's the kind of detail we can settle with multiple sets of eyes at review
time.)
I know you're looking at this targeting GSoC, so for the the sake of a
proposal, noting the areas to be decided is OK. Showing that you've
considered points already raised is important — make sure you looked at
[https://github.com/django/django/pull/15529#issuecomment-1073412321
Simon's comment on your draft PR] — I'm sure you did. Plus #33626 and the
PR there you've made are all good signs — that's on my list to review next
week.
I hope that helps. 🙂
--
Ticket URL: <https://code.djangoproject.com/ticket/29799#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/010701800a9af916-8b73693a-958b-406a-afd9-0bd2b8970b75-000000%40eu-central-1.amazonses.com.
