#33750: Use <div> for timezone warning in admin
------------------------------------------------+--------------------------
               Reporter:  Florian Demmer        |          Owner:  nobody
                   Type:  Cleanup/optimization  |         Status:  assigned
              Component:  contrib.admin         |        Version:  4.0
               Severity:  Normal                |       Keywords:
           Triage Stage:  Unreviewed            |      Has patch:  1
    Needs documentation:  0                     |    Needs tests:  0
Patch needs improvement:  0                     |  Easy pickings:  0
                  UI/UX:  1                     |
------------------------------------------------+--------------------------
 Previously help_text was inserted as <p> in admin. This was changed in
 #27207 to use a <div>.

 The
 
[https://github.com/django/django/blob/0dd29209091280ccf34e07c9468746c396b7778e/django/contrib/admin/static/admin/js/admin/DateTimeShortcuts.js#L61
 addTimezoneWarning()] function has "always" added the warning by inserting
 a <br> and <span>.

 Also using a <div> with the help class here avoids problems with left-
 alignment of the inserted text and removes the need for the <br>.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33750>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018110256a3d-e94da506-edd2-4956-8cb0-7fb62adcd460-000000%40eu-central-1.amazonses.com.

Reply via email to