#6058: 6776 mark_safe breaks newforms_admin
------------------------------+---------------------------------------------
Reporter: tvrg | Owner: tvrg
Status: new | Component: Admin interface
Version: newforms-admin | Resolution:
Keywords: newforms-admin | Stage: Ready for checkin
Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 0
------------------------------+---------------------------------------------
Comment (by Karen Tracey <[EMAIL PROTECTED]>):
Yes, the change to django/contrib/admin/templates/admin/change_form.html
is an alternative fix for #6059. I took the approach of using mark_safe on
the variable before sending it to the template instead of using the safe
filter in template...got the impression from other code this was a
preferred way to handle it?
The changes to django/contrib/admin/widgets.py are similarly covered by
#6060, though the #6060 patch also attempts to mark_safe the output of the
!AdminSplitDateTime widget, so there's a slight difference there.
I haven't yet run into the problems requiring the changes to:
django/contrib/admin/templates/admin/change_list_results.html
django/contrib/admin/templates/admin/includes/fieldset.html
django/newforms/widgets.py
so they might be needing their own tickets, since Malcolm indicates we
should stick to one issue per ticket. Though I also see how this could be
viewed as all one big issue -- autoescape and newforms-admin...
--
Ticket URL: <http://code.djangoproject.com/ticket/6058#comment:5>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
