#34051: makemigrations --check generating migrations is inconsistent with other uses of --check ------------------------------------------------+------------------------ Reporter: Jacob Walls | Owner: nobody Type: Cleanup/optimization | Status: new Component: Migrations | Version: dev Severity: Normal | Keywords: Triage Stage: Unreviewed | Has patch: 0 Needs documentation: 0 | Needs tests: 0 Patch needs improvement: 0 | Easy pickings: 0 UI/UX: 0 | ------------------------------------------------+------------------------ To script a check for missing migrations but without actually intending to create the migrations, it is necessary to use both `--check` and `--dry- run`, which is inconsistent with `migrate --check` and `optimizemigration --check`, which just exit (after possibly logging a bit).
I'm suggesting that `makemigrations --check` should just exit without making migrations. The choice to write the migrations anyway was not discussed AFAICT on ticket:25604 or https://groups.google.com/g/django- developers/c/zczdY6c9KSg/m/ZXCXQsGDDAAJ. Noticed when reading [https://github.com/django/django/pull/15845#issue-1305277307 PR to adjust the documentation of migrate --check]. I think the current documentation is silent on this question. -- Ticket URL: <https://code.djangoproject.com/ticket/34051> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/0107018372e79ed1-35fe7894-f34c-4256-9497-329c2f2acbac-000000%40eu-central-1.amazonses.com.