#34050: Generated migration file is not detected by django because of the name 
of
newly generated migration file
-------------------------------+-----------------------------------------
     Reporter:  Bishal Gautam  |                    Owner:  Bishal Gautam
         Type:  Bug            |                   Status:  assigned
    Component:  Migrations     |                  Version:  4.1
     Severity:  Normal         |               Resolution:
     Keywords:  migrations     |             Triage Stage:  Unreviewed
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  1              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+-----------------------------------------
Changes (by David Sanders):

 * owner:  nobody => Bishal Gautam
 * status:  new => assigned
 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 Can confirm this.

 It's worth highlighting is that migrations literally copies the constraint
 name verbatim for **any** invalid Python module character not just dots
 "." and will happily apply these (as long as there's no dots) – as long as
 we're not doing any imports of migrations we should be fine.

 The PR replaces the dots with underscores - that's one solution which
 addresses the immediate issue but I'm just wondering whether:

 a.) Any invalid character is replaced to ensure there are no more problems
 like this; or
 b.) Migrations (ie `showmigrations` and `migrate`) do not look skip files
 with multiple dots?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34050#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701837301d73a-1037dfec-0992-4eb3-b07d-639abeb4b747-000000%40eu-central-1.amazonses.com.

Reply via email to