#34085: Black shouldn't format non-Python files
-------------------------------------+-------------------------------------
Reporter: Jeff Triplett | Owner: nobody
Type: Bug | Status: closed
Component: Core (Management | Version: 4.1
commands) |
Severity: Normal | Resolution: needsinfo
Keywords: startproject black | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* status: new => closed
* resolution: => needsinfo
Comment:
Hmm. This doesn't reproduce for me locally, so we're missing something...
🤔
{{{
Last login: Tue Oct 11 10:24:11 on ttys000
carlton@Carltons-MacBook-Pro ~ % mktmpenv
...
(tmp-485998ddadf9b85) carlton@Carltons-MacBook-Pro tmp-485998ddadf9b85 %
pip install Django
...
Successfully installed Django-4.1.2 asgiref-3.5.2 sqlparse-0.4.3
(tmp-485998ddadf9b85) carlton@Carltons-MacBook-Pro tmp-485998ddadf9b85 %
django-admin startproject \
--extension=ini,py,yml \
--template=https://github.com/jefftriplett/django-
startproject/archive/main.zip \
example_project
(tmp-485998ddadf9b85) carlton@Carltons-MacBook-Pro tmp-485998ddadf9b85 %
cat example_project/requirements/requirements.in
django-click
Django<4.2
environs[django]
psycopg2-binary
whitenoise
black
django-test-plus
ipdb
model-bakery
pip-tools
pytest
pytest-cov
pytest-django
(tmp-485998ddadf9b85) carlton@Carltons-MacBook-Pro tmp-485998ddadf9b85 %
black --version
black, version 21.10b0
}}}
Do you think Oliver could dig in a bit to spot where the issue is coming
up? 🤔
> While I am a fan of Black, I personally think we should have some type
of --skip-black or --skip-formatters because it's disruptive to have Black
installed globally and have this be opt-in by default.
This was discussed (at some length) during the development of the feature.
It was decided against. Rather set the `PATH` explicitly if you have black
installed globally but **do not** want to apply it for a particular
invocation.
--
Ticket URL: <https://code.djangoproject.com/ticket/34085#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070183c83d4991-f6902649-8d34-4b16-abce-d9735c28e257-000000%40eu-central-1.amazonses.com.
