#34095: Form controls in admin should use heights in relative units
-------------------------------+------------------------------------
Reporter: Thibaud Colas | Owner: jer
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* has_patch: 1 => 0
Comment:
There are still
[https://github.com/django/django/pull/16180#issuecomment-1278514250 more
cases to fix], see Thibaud's comment:
> ''"Basically anything that contains text and has a height, max-height or
line-height set in pixels is suspect."''
>
> ''"Here is a regex that identifies what to review: (max-height|height
|line-height):.+px. Then for each of the definitions this identifies, we
need to find the corresponding part of the UI, and check whether it makes
sense for it to scale with the font size (if so – convert to `rem). Or
whether it better stay at the fixed size."''
--
Ticket URL: <https://code.djangoproject.com/ticket/34095#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018441de303a-4862cf7f-1c39-471d-820e-88dea31d3a03-000000%40eu-central-1.amazonses.com.
