#34172: Documentation of AdminSite.get_urls() encourages security 
vulnerabilities
------------------------------------+--------------------------------------
     Reporter:  Sylvain Fankhauser  |                    Owner:  nobody
         Type:  Uncategorized       |                   Status:  new
    Component:  contrib.admin       |                  Version:  4.1
     Severity:  Normal              |               Resolution:
     Keywords:                      |             Triage Stage:  Unreviewed
    Has patch:  0                   |      Needs documentation:  0
  Needs tests:  0                   |  Patch needs improvement:  0
Easy pickings:  0                   |                    UI/UX:  0
------------------------------------+--------------------------------------

Comment (by Mariusz Felisiak):

 `get_urls()` docs contains a step by step example with further required
 elements, first an example without `admin_view()`, than comments what is
 missing:

 > ''However, the self.my_view function registered above suffers from two
 problems:''
 > ''- It will not perform any permission checks, so it will be accessible
 to the general public.''

 and a second example with the `admin_view()` wrapper. I wouldn't change
 anything, IMO it's nicely constructed.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34172#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701849b892bdf-652c3738-2dbc-4334-b91b-d9ef4255aab3-000000%40eu-central-1.amazonses.com.

Reply via email to