#34378: Using in_bulk() with id_list and order_by() -------------------------------------+------------------------------------- Reporter: Ekaterina | Owner: Ekaterina Vakhrusheva | Vakhrusheva Type: Bug | Status: assigned Component: Database layer | Version: 4.1 (models, ORM) | Severity: Normal | Resolution: Keywords: ib_bulk | Triage Stage: Accepted Has patch: 0 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 | UI/UX: 0 -------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak): [https://docs.djangoproject.com/en/dev/internals/contributing/writing-code /coding-style/ "Coding style"] can also be helpful. This is a bugfixes so docs changes are not necessary. We need a fix (it should be enough to remove `order_by()` from the `in_bulk()` [https://github.com/django/django/blob/9953c804a9375956a542da94665662d306dff48d/django/db/models/query.py#L1107-L1113 implementation]) and regression tests in `tests.lookup.tests.LookupTests` (please be sure that you covered both branches, with and without `batch_size`). -- Ticket URL: <https://code.djangoproject.com/ticket/34378#comment:8> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/01070186a18987fe-5c88e5dc-1f27-445f-9f73-0921d71c07dc-000000%40eu-central-1.amazonses.com.