#34966: Add a check for ModelAdmin.actions functions not taking three arguments
-------------------------------------+-------------------------------------
     Reporter:  Riccardo             |                    Owner:  nobody
  Magliocchetti                      |
         Type:  New feature          |                   Status:  closed
    Component:  contrib.admin        |                  Version:  dev
     Severity:  Normal               |               Resolution:  wontfix
     Keywords:  admin actions        |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Hello Riccardo, thank you for your ticket and interest to make Django
 better.

 I understand your report, but Django can not possibly add checks for every
 function or method signature that Django users create when using the
 framework. In my experience, these errors are better caught by unit tests,
 there are plenty of examples in the Django source code and in other open
 projects that would provide examples about how to test Admin actions.

 Did you have unit tests that did not catch this? If so, perhaps you could
 seek further help in how to improve/fix those by using any of the user
 support channels from [https://docs.djangoproject.com/en/dev/faq/help
 /#how-do-i-do-x-why-doesn-t-y-work-where-can-i-go-to-get-help this link].
 I'll be closing this ticket as wontfix following the
 [https://docs.djangoproject.com/en/4.2/internals/contributing/triaging-
 tickets/#closing-tickets ticket triaging process].

 Thanks again!

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34966#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018bc8c0bfde-8d17c575-42ce-4eb9-b6a3-70fa688ad285-000000%40eu-central-1.amazonses.com.

Reply via email to