#14831: Django Template Style Guide
-------------------------------------+-------------------------------------
     Reporter:  Simon Meers          |                    Owner:  Ryan
                                     |  Cheley
         Type:  New feature          |                   Status:  assigned
    Component:  Documentation        |                  Version:  1.2
     Severity:  Normal               |               Resolution:
     Keywords:  template, style,     |             Triage Stage:  Accepted
  format                             |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Ryan Cheley):

 Replying to [comment:14 Ryan Cheley]:
 > I moved the `{% load log %}` from line 25 to line 3 and there weren't
 any NEW test failures. Once a standard is decided on this could
 potentially be moved to the top and it doesn't look like any negative
 impact would be introduced (from a testing perspective anyway).
 >
 > Next step is to create a Django app locally and see what happens

 App locally seems to be behaving as expected.

 Also, in reading the docs I was reminded that a `{% load ... %}` can have
 more than one template tag added, so the two outliers here can be moved up
 into a single `{% load ... }` command instead of multiple lines

 This means that

 * /django/contrib/admin/templates/admin/auth/user/change_password.html can
 have line 2 updated to `{% load i18n static admin_urls %}`
 * ./django/contrib/admin/templates/admin/index.html can have line 2
 updated to be `{% load i18n static log %}`

-- 
Ticket URL: <https://code.djangoproject.com/ticket/14831#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d040cbd72-25520f98-a4af-4c5a-9eae-d84c9c448cf3-000000%40eu-central-1.amazonses.com.

Reply via email to