#29167: HashedFilesMixin doesn't work with data URIs that include a closing
parenthesis
-------------------------------------+-------------------------------------
Reporter: Clem Flory | Owner: Adam
| Zapletal
Type: Bug | Status: closed
Component: contrib.staticfiles | Version: 2.0
Severity: Normal | Resolution:
| worksforme
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* resolution: => worksforme
* stage: Accepted => Unreviewed
* status: assigned => closed
Comment:
Closing as "worksforme" unless someone can provide a reproducible
scenario. Thanks Adam Zapletal for the investigation:
> ''I tested this all the way back to Django v2.0.2, which is the release
the bug reporter was probably using, and Python 3.8. I wasn't able to
reproduce the bug. In the process, I realized that Django has been
skipping the processing of `data:` URLs since
46c12d1293aa90209f3c640f214c4b5a3d6cb9e6. That was well before the version
specified on the ticket.''
>
> ''Other than adding named groups, I don't think the regex in question
has changed at all since it was initially added in
1d32bdd3c9586ff10d0799264105850fa7e3f512. The ticket is correct in that
the regex doesn't match to the final closing parenthesis, but it doesn't
need to because `data:` URLs are skipped.''
>
> ''I'm unsure how the bug reporter was able to get unexpected behavior. I
doubt that this PR is even needed since there's already an assert for
`data:` URLs in the tests, and I wonder if the ticket is even valid.''
--
Ticket URL: <https://code.djangoproject.com/ticket/29167#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018dc4d42783-d7cc158b-5780-40f1-8f79-bfab16824ddd-000000%40eu-central-1.amazonses.com.
