#35270: Optimize Model._meta._property_names -------------------------------------+------------------------------------- Reporter: Adam Johnson | Owner: Adam Type: | Johnson Cleanup/optimization | Status: assigned Component: Database layer | Version: dev (models, ORM) | Severity: Normal | Resolution: Keywords: | Triage Stage: | Unreviewed Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 | UI/UX: 0 -------------------------------------+------------------------------------- Comment (by Natalia Bidart):
I'm not so sure about this one, particularly after having read the history in the relevant PRs ([https://github.com/django/django/pull/7598 the original optimization in this code] and [https://github.com/django/django/pull/8599 its regression fix]). I wonder, would using [https://github.com/django/django/pull/8601 the solution proposed for "1.11.x"] be an option for getting rid of `inspect.getattr_static`? I'm not a fan of the custom weak key cache, it feels like an unnecessary adding to the framework only for optimization purposes. -- Ticket URL: <https://code.djangoproject.com/ticket/35270#comment:2> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/0107018e0c37ef48-94257e51-eb4e-473b-83f3-32323a6c69e7-000000%40eu-central-1.amazonses.com.