#35233: Push templates checks down to backend engine classes
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Giannis
Type: | Terzopoulos
Cleanup/optimization | Status: assigned
Component: Core (System | Version: dev
checks) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Adam Johnson):
> Regarding this, am I right in assuming that we want to allow same names
for tags across different engines; Should this test pass?
Yes, I think so. You can use two `DjangoTemplates` backends and it would
still be valid.
> And one more thing, I am noticing that the E001 logic is duplicated:
Indeed, that is true. The system check was added in #24922 because the
exception would only appear at runtime, because the backend would only be
created lazily. But by actioning this ticket, we’ll force backends to all
be instantiated during checks, which will make the exception appear then.
So we should be able to remove E001 as part of this work.
--
Ticket URL: <https://code.djangoproject.com/ticket/35233#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018e2a6da869-ae3091ef-89c9-482d-aa2a-4a7d76661a5b-000000%40eu-central-1.amazonses.com.
