#35338: Behaviour change in URL patterns.
--------------------------------+--------------------------------------
Reporter: Carlton Gibson | Owner: nobody
Type: Bug | Status: new
Component: Core (URLs) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+--------------------------------------
Description changed by Carlton Gibson:
Old description:
> There's a behaviour change on `main` pre-5.1 in
> 5dfcf343cd414d3f7a33dabb763b4478fa081d72 for #35250.
>
> {{{
>
> commit 5dfcf343cd414d3f7a33dabb763b4478fa081d72
> Author: Adam Johnson <m...@adamj.eu>
> Date: Sat Feb 24 19:14:22 2024 +0000
>
> Refs #35250 -- Avoided double conversion in RoutePattern.
>
> django/urls/resolvers.py | 58
> ++++++++++++++++++++++++++++++------------------
> 1 file changed, 36 insertions(+), 22 deletions(-)
>
> }}}
>
> Since this commit, there are two failures in the Channels test suite.
>
> {{{
> $ pytest -k test_routing.py
>
> ...
>
> =========================== short test summary info
> ============================
> FAILED tests/test_routing.py::test_url_router_nesting_path - ValueError:
> No r...
> FAILED tests/test_routing.py::test_path_remaining - ValueError: No route
> foun...
> ================== 2 failed, 6 passed, 55 deselected in 0.07s
> ==================
> }}}
>
> See CI run here:
> https://github.com/django/channels/actions/runs/8467612542/job/23198786518#step:5:342
New description:
There's a behaviour change on `main` pre-5.1 in
5dfcf343cd414d3f7a33dabb763b4478fa081d72 for #35250.
{{{
commit 5dfcf343cd414d3f7a33dabb763b4478fa081d72
Author: Adam Johnson <m...@adamj.eu>
Date: Sat Feb 24 19:14:22 2024 +0000
Refs #35250 -- Avoided double conversion in RoutePattern.
django/urls/resolvers.py | 58
++++++++++++++++++++++++++++++------------------
1 file changed, 36 insertions(+), 22 deletions(-)
}}}
Since this commit, there are two failures in the Channels test suite.
{{{
$ pytest -k test_routing.py
...
=========================== short test summary info
============================
FAILED tests/test_routing.py::test_url_router_nesting_path - ValueError:
No r...
FAILED tests/test_routing.py::test_path_remaining - ValueError: No route
foun...
================== 2 failed, 6 passed, 55 deselected in 0.07s
==================
}}}
See CI run here:
https://github.com/django/channels/actions/runs/8467612542/job/23198786518#step:5:342
Tracking issue on django/channels:
https://github.com/django/channels/issues/2084
--
--
Ticket URL: <https://code.djangoproject.com/ticket/35338#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018e85535b37-265f6c91-ce97-4c18-b3e2-211787b2d118-000000%40eu-central-1.amazonses.com.
