#35492: Replace call to User.set_password with make_password in authenticate
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz):
I'm still a bit undecided on this. The call in `authenticate` is counting
on the fact that `check_password` (itself calling `set_password`) is using
more or less the same time than `set_password`. If we call `make_password`
instead, wouldn't this open a timing effect attack vector for any project
doing any not-negligible work in a customized `set_password`? Hence I'm
not sure that changing the function to call is not simply moving a
potential problem elsewhere.
--
Ticket URL: <https://code.djangoproject.com/ticket/35492#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018fced1e77b-de6de512-96d3-42e7-8e21-5e599c271ee5-000000%40eu-central-1.amazonses.com.
