#36247: BaseGeometryWidget unncessarily writes an error log when deserializing
malformed geometry
-------------------------------------+-------------------------------------
Reporter: David Buhler | Owner: hesham
Type: | hatem
Cleanup/optimization | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):
* stage: Ready for checkin => Accepted
Comment:
Hello Hesham! I need to kindly ask you to please read the
[https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
/submitting-patches/#contribution-checklist contributing checklist] docs
carefully as they state that:
> If the pull request passes all the criteria below **and is not your
own**, please set the “Triage Stage” on the corresponding Trac ticket to
“Ready for checkin”.
Special attention to "and is not your own". You should not set your own PR
was ready for checkin. This will be done by a reviewer once your PR is
reviewed and approved. When I mentioned in another PR that you need to
update the ticket flags, this is not the ticket "Triage Stage", but the
booleans "has patch", "patch needs improvement" and "needs tests". I hope
this makes sense!
--
Ticket URL: <https://code.djangoproject.com/ticket/36247#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070195a5412c2e-68f10de1-dce0-4937-8ab7-3d54ff3869ea-000000%40eu-central-1.amazonses.com.
