#36618: BaseForm.add_error() misleading exception message when both field and 
dict
provided
--------------------------------------+------------------------------------
     Reporter:  Chris Brand           |                    Owner:  (none)
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Forms                 |                  Version:  5.2
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  1                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Jacob Walls):

 * component:  Uncategorized => Forms
 * easy:  0 => 1
 * stage:  Unreviewed => Accepted
 * summary:  Forms.add_error() misleading exception message =>
     BaseForm.add_error() misleading exception message when both field and
     dict provided
 * type:  Uncategorized => Cleanup/optimization

Comment:

 Good spot, happy to take a PR replacing the reference to "multiple fields"
 with a mention of a dictionary instead. Incidentally this condition
 [https://djangoci.com/view/%C2%ADCoverage/job/django-
 coverage/HTML_20Coverage_20Report/ isn't tested], so we'll benefit from
 the addition of a test.
-- 
Ticket URL: <https://code.djangoproject.com/ticket/36618#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/010701997948ae01-52755715-6369-4e25-ac17-bc2dd1acc6a0-000000%40eu-central-1.amazonses.com.

Reply via email to