#36659: Re-enable custom height for flatpage content field in admin
-------------------------------------+-------------------------------------
     Reporter:  Baptiste Mispelon    |                     Type:  Bug
       Status:  new                  |                Component:
                                     |  contrib.admin
      Version:  5.2                  |                 Severity:  Normal
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
 The admin's `forms.css` file contains this rule [1]:

 {{{#!css
 .flatpages-flatpage #id_content {
     height: 40.2em;
 }
 }}}

 The purpose of this rule (I'm guessing) is to make the `FlatPage.content`
 field taller on the add/change form, because this field typically contains
 a lot of text. This appears to be basically as old as the admin itself,
 and was added in dd5320d1d56ca7603747dd68871e72eee99d9e67 (where it
 started as `body.core-flatfile #id_content { height: 400px; }`).

 However this rule doesn't currently do anything, because the `.flatpages-
 flatpage` selector doesn't match anything.

 This appears to be a regression that was introduced in release 1.6 with
 commit bb145e2c47d71b7f68280c00ced727442d2effa2 wich effectively changed
 the body class from `flatpages-flatpage` to `app-flatpages model-
 flatpage`.

 [1]
 
https://github.com/django/django/blob/1167cd1d639c3fee69dbdef351d31e8a17d1fedf/django/contrib/admin/static/admin/css/forms.css#L360-L362
-- 
Ticket URL: <https://code.djangoproject.com/ticket/36659>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/01070199d4703f24-d8b77799-dcc4-4b69-ae1d-33d5a80da942-000000%40eu-central-1.amazonses.com.

Reply via email to