#36674: select_related() leaks memory
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: nzioker
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):
* needs_better_patch: 0 => 1
Comment:
MR was targeting 4.2.
Also it appears that my analysis was wrong. Since we're recursively
calling the function it'd be better if it was a `classmethod` instead so
we can do `cls.get_select_from_parent(ki)` in the function definition. We
should also do `self.get_select_from_parent` instead of
`SQLCompiler.get_select_from_parent` in `.get_select`.
--
Ticket URL: <https://code.djangoproject.com/ticket/36674#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019a06cb232e-5f8e978a-3b7e-4dde-89fb-aae47bd0378f-000000%40eu-central-1.amazonses.com.
