#36680: Formatters run on `TemplateCommand` make `admin_scripts` tests brittle
-------------------------------------+-------------------------------------
Reporter: Natalia Bidart | Owner: Jacob
| Walls
Type: Bug | Status: closed
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Hal Blackburn):
I realise this ticket is closed, but I ran into this issue again (despite
it being fixed) when I was working on the PR for ticket:36704. I found
several admin_scripts tests were failing on a clean checkout after
following the repo's instructions to run tests. The fix here didn't stop
the tests failing when black is on the PATH in more than one place. (e.g.
when it's installed globally via pipx or a system package manager). I've
got a PR to extend the current fix to handle multiple instances of black
on the PATH, but I've not discussed here ahead of time as it was a small
thing to fix while working on the other ticket:
https://github.com/django/django/pull/20054
--
Ticket URL: <https://code.djangoproject.com/ticket/36680#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019a4e1937f1-d11051c0-282e-4807-a718-ada6f2a66da7-000000%40eu-central-1.amazonses.com.
