#36663: Make management commands default to running checks against all databases
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Simon
| Charette
Type: Bug | Status: assigned
Component: Core (System | Version: dev
checks) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Simon Charette):
You might have noticed it during the review Tim but the proposed patch
happens to achieve exactly what you're after.
Since the implicit exclusion of `Tags.databases`
[https://github.com/django/django/commit/0b83c8cc4db95812f1e15ca19d78614e94cf38dd
#diff-
f10ce154e1f5bcdba92b54ebf8cb57357b404a3f03ab51ca85a031358f7372ecL66-L69 is
no longer applied] all checks (including the `Tags.databases` ones) are
now performed on all management commands unless `--database` is specified.
A problem I see with this approach is that since system checks are
performed by management commands by default (unless they are marked with
`requires_system_checks = False`) it means that users who might be
interested achieving the previous behaviour cannot and must use `--skip-
checks` to disable all of them. This is fine by me but I wanted to flag it
for reviewers as I'll adjust the documentation accordingly.
--
Ticket URL: <https://code.djangoproject.com/ticket/36663#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019a650456c1-577a7518-14c7-4ba0-a07e-6dde77f99f49-000000%40eu-central-1.amazonses.com.
