#36801: `construct_change_message`call `form.changed_data` after check if is add
-------------------------------------+-------------------------------------
Reporter: Rodolfo Becerra | Owner: Rodolfo
Type: | Becerra
Cleanup/optimization | Status: closed
Component: contrib.admin | Version:
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage:
construct_change_message | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):
* resolution: => needsinfo
* status: assigned => closed
Comment:
Hi Rodolfo. So `changed_data` is a cached property to avoid having to
reason about this in various places. Given that, I'm inclined to close as
`needsinfo` pending a benchmark showing this is worth devoting a review
cycle to. This is generally how we handle all optimization proposals.
--
Ticket URL: <https://code.djangoproject.com/ticket/36801#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019b248de68c-42312150-9db1-4ff9-a46b-36dcd7cdcb75-000000%40eu-central-1.amazonses.com.
