#36817: Possible regression of Engine.get_template
-------------------------------------+-------------------------------------
Reporter: Henrik Ossipoff | Type: Bug
Hansen | Component: Template
Status: new | system
Version: 6.0 | Severity: Normal
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
While trying to upgrade to Django 6.0 locally today, we noticed an issue
with one of our third party packages, adminsortable2.
For their admin templates, they use Path objects: https://github.com/jrief
/django-admin-sortable2/blob/master/adminsortable2/admin.py#L124
This has worked until this commit
https://github.com/django/django/commit/5e06b970956af4854e970e74990cb971ba31c96b
where get_template was refactored to support Template Partials.
As a by-product, template names now have to be strings.
I don't see that it was ever mentioned/officially supported, to use Path
objects for templates, but I would suspect that several third party
libraries does this, and I would therefore see this as a regression.
If this is deemed not to be the case, I'll create an issue on their Github
to change the behaviour.
--
Ticket URL: <https://code.djangoproject.com/ticket/36817>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019b45431934-8dbdbd4b-e4c5-4a72-a490-d8013c142105-000000%40eu-central-1.amazonses.com.
