#32213: QuerySet.values()/.values_list() on KeyTransforms return wrong values
for
double-quoted strings on SQLite and Oracle
-------------------------------------+-------------------------------------
Reporter: Sage Abdullah | Owner: VIZZARD-X
Type: Bug | Status: assigned
Component: Database layer | Version: 3.1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: sqlite oracle json | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
Comment:
Left some comments for improvements on the PR mainly
1. The solution should use `KeyTransform.select_format` and not override
`JSONField.from_db_value` with `KeyTransform` specific logic
2. Existing testing setup (models, test classes) should be used instead of
a per-ticket model and test module and test case class
--
Ticket URL: <https://code.djangoproject.com/ticket/32213#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019b84821a1b-18cced79-145e-42dd-a588-1b26fc519f33-000000%40eu-central-1.amazonses.com.
