#36850: Django Admin filter sidebar wraps if its inner content becomes too large
---------------------------------+-----------------------------------------
Reporter: Mark | Owner: Nilesh Pahari
Type: Bug | Status: assigned
Component: contrib.admin | Version: 6.0
Severity: Release blocker | Resolution:
Keywords: css | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+-----------------------------------------
Changes (by Jacob Walls):
* cc: Antoliny (added)
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
Old description:
> In the course of ticket [https://code.djangoproject.com/ticket/36511
> #36511] the layout of the changelist and its filter sidebar has been
> changed so that the sidebar seemingly should have a fixed width of 240px.
>
> The flex-base property does not necessarily restrict the width of the
> sidebar if it's content demands more (which happens eg. for dropdowns
> with large titles). Combined with the flex: wrap attribute, the sidebar
> wraps if the table also demands more width than available and looks
> broken (see attachment).
>
> This behavior can be simulated by giving a sidebar's and changelist's
> children some fixed, large width:
>
> {{{
> #changelist-filter-extra-actions {
> width: 290px;
> }
> #toolbar {
> width: 1000px;
> }
> }}}
>
> The problem could be resolved by reverting to the previous flex layout,
> but the motivation for those changes is unclear to me from the ticket and
> [https://github.com/django/django/pull/19659 related pr].
>
> Should the width of the sidebar stick to 240px or - at it has been before
> - should the sidebar grow if necessary?
>
> Does the new flex layout have any advantages to how it was in django <6?
New description:
In the course of ticket #36511 the layout of the changelist and its filter
sidebar has been changed so that the sidebar seemingly should have a fixed
width of 240px.
The flex-base property does not necessarily restrict the width of the
sidebar if it's content demands more (which happens eg. for dropdowns with
large titles). Combined with the flex: wrap attribute, the sidebar wraps
if the table also demands more width than available and looks broken (see
attachment).
This behavior can be simulated by giving a sidebar's and changelist's
children some fixed, large width:
{{{
#changelist-filter-extra-actions {
width: 290px;
}
#toolbar {
width: 1000px;
}
}}}
The problem could be resolved by reverting to the previous flex layout,
but the motivation for those changes is unclear to me from the ticket and
[https://github.com/django/django/pull/19659 related pr].
Should the width of the sidebar stick to 240px or - at it has been before
- should the sidebar grow if necessary?
Does the new flex layout have any advantages to how it was in django <6?
--
--
Ticket URL: <https://code.djangoproject.com/ticket/36850#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019ba40fa3a3-ea577caa-4324-4e69-b947-a11e8dff4d88-000000%40eu-central-1.amazonses.com.
