#9199: Common middleware PREPEND_WWW broken
-------------------------------------+--------------------------------------
Reporter: gonz | Owner: nobody
Status: new | Milestone:
Component: Core framework | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
-------------------------------------+--------------------------------------
Changes (by mtredinnick):
* needs_better_patch: 0 => 1
* needs_tests: 1 => 0
Comment:
No, this patch is bad. The problem report looks valid enough, but it
doesn't seem to be caused by this line (or, if it is, it needs to be fixed
differently). Any calls to Django's URL resolver ''must'' use
`request.path_info` and `new_url[1]` is the same as `request.path`, which
will include the `SCRIPT_NAME` prefix. Django's URL resolver doesn't care
(and shouldn't know) about the script name prefix -- it won't work if you
pass in something with such a script name. That's exactly why r8456 was
introduced (as discussed in the ticket the changeset refers to; all the
history is available).
This stuff is almost impossible to test in the automated test suite as a
practical matter, since it requires control over domain names and
installation paths, so I'm not too worried about manual testing for this
stuff. But the patch still has to be correct.
--
Ticket URL: <http://code.djangoproject.com/ticket/9199#comment:3>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
