#9335: TypedChoiceField, default empty value not unicode
-------------------------------+--------------------------------------------
Reporter: fas | Owner: fas
Status: new | Milestone: post-1.0
Component: Forms | Version: 1.0
Resolution: | Keywords: TypedChoiceField, unicode,
empty, data truncated for column
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
-------------------------------+--------------------------------------------
Changes (by kmtracey):
* needs_tests: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
This looks harmless, and maybe I'm a bit dim, but I'm missing how
returning `''` instead of `u''` can lead to 'Data truncated for column'
errors. A test that exhibits the problem -- failing before the change,
passing after it -- would help clarify. Even one-liner fixes deserve
tests. Also, you're really not supposed to triage your own patches into
'ready for checkin' -- that's supposed to indicate another set of eyes has
looked it over and agrees with the problem & fix.
--
Ticket URL: <http://code.djangoproject.com/ticket/9335#comment:2>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
