#8754: PYTHONPATH not passed through to regressiontests/admin_scripts/AdminScriptTestCase.run_test() -----------------------------------------------------------------------+---- Reporter: Richard Davies <[EMAIL PROTECTED]> | Owner: nobody Status: new | Milestone: Component: Testing framework | Version: SVN Resolution: | Keywords: Stage: Unreviewed | Has_patch: 1 Needs_docs: 0 | Needs_tests: 0 Needs_better_patch: 0 | -----------------------------------------------------------------------+---- Comment (by kmtracey):
This same problem was fixed once before, in [8149], but then it was un- done in [8238] for reasons I don't quite follow (having no Jython experience). Subsequently [8400] added use of JYTHONPATH instead of PYTHONPATH when running Jython. Given the way the code is written now, the current patch will append any pre-existing JYTHONPATH setting to the one used for the subprocess, yet the ticket that introduced use of JYTHONPATH (#8268) specifically says JYTHONPATH "should be cleared before calling a jython subprocess". So while it seems the patch would be fine for Python (it's essentially what was done in r8149) I'm concerned about the Jython implications. Though perhaps now that different names are being used for the environment variables the issue behind [8238] that caused the removal is no longer a factor? (Or it could be the discarding of use of old_python_path is [8238] was inadvertent -- that changeset is not very clear to me.) Could someone involved in those earlier changesets give an opinion on this patch? -- Ticket URL: <http://code.djangoproject.com/ticket/8754#comment:3> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-updates?hl=en -~----------~----~----~----~------~----~------~--~---