#8898: `required` validation bypassed when using `DateTimeField` with `SplitDateTimeWidget`. --------------------------------+------------------------------------------- Reporter: mrmachine | Owner: nobody Status: new | Milestone: Component: Forms | Version: SVN Resolution: | Keywords: DateTimeField SplitDateTimeWidget Stage: Accepted | Has_patch: 1 Needs_docs: 0 | Needs_tests: 0 Needs_better_patch: 0 | --------------------------------+------------------------------------------- Comment (by kmtracey):
I don't believe the patch is correct as coded. !DateTimeField is documented to return None for an empty value (http://docs.djangoproject.com/en/dev/ref/forms/fields/#datetimefield) and the patch has it returning a list in the case of empty input from a !SplitDateTimeWidget. But it's not necessary to post another patch because that I could fix myself. Before fixing this I think it would be good to understand why !DateTimeField is even worried about getting input from a !SplitDateTimeWidget. As noted above, it seems that is what !SplitDateTimeField is for? The code was added in [6577] without reference to a ticket. Malcolm, do you recall why you added this? And do you have any recommendation as to whether it would be better to remove the half-working support entirely, make a fix along the lines of the patch, or ...? Strict backwards-compatibility would seem to require we can't remove it at this point.... -- Ticket URL: <http://code.djangoproject.com/ticket/8898#comment:6> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-updates?hl=en -~----------~----~----~----~------~----~------~--~---