#9610: File upload duplicate filename check mechanism fail
-------------------------------------------+--------------------------------
          Reporter:  fadlytabrani          |         Owner:  fadlytabrani
            Status:  closed                |     Milestone:  post-1.0    
         Component:  File uploads/storage  |       Version:  1.0         
        Resolution:  worksforme            |      Keywords:              
             Stage:  Unreviewed            |     Has_patch:  1           
        Needs_docs:  0                     |   Needs_tests:  0           
Needs_better_patch:  1                     |  
-------------------------------------------+--------------------------------
Changes (by dc):

  * needs_better_patch:  0 => 1

Comment:

 Replying to [comment:4 fadlytabrani]:

 > The line should be within the while loop to acommodate checking more
 than once

 Nope. dir_name never changes and it should be calculated once. But your
 version calls unneeded split every iteration. Just check in debugger (or
 something like that) if you unsure.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/9610#comment:7>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to