#9654: `list_display_links` does not respect an empty tuple. ----------------------------------+----------------------------------------- Reporter: mdh | Owner: nobody Status: new | Milestone: Component: django.contrib.admin | Version: 1.0 Keywords: | Stage: Unreviewed Has_patch: 1 | ----------------------------------+----------------------------------------- The admin's change list page will link the first column to the change page for each item even if you explicitly specify an empty tuple as the value of `list_display_links`. Although it is unusual not to want any of the columns to link to the default change page, this can come up if you are using other extensions to the admin to build a custom interface for a given model. The underlying issue is very easy to address: it arises because the admin uses an empty tuple as the default value, when it could just as easily have used `None` as the default value instead.
I've attached a simple patch. It's not obvious to me how to test this with the test fixtures currently available, so I haven't written any tests. If people like this but think it needs tests and can give me a hint about how to approach them I'd be happy to write them. -- Ticket URL: <http://code.djangoproject.com/ticket/9654> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-updates?hl=en -~----------~----~----~----~------~----~------~--~---
