#10196: width/height_field not being set on ImageField
-------------------------------------------+--------------------------------
Reporter: vicvicvic | Owner: nobody
Status: new | Milestone:
Component: File uploads/storage | Version: SVN
Resolution: | Keywords: imagefield,
width_field
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------------+--------------------------------
Changes (by kmtracey):
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
Comment:
Attached patch with integrated tests. Tests verify width/height are set
and re-set properly (and rely on a 2nd .png file with different size which
I don't think can be included in the attached diff since it's binary, but
I have it). Tests pass on 1.0.X branch, fail on current trunk, pass with
the fix in the patch.
There really should be one more test, that verifies for a blank=True
!ImageField, once a value for the !ImageField has been set, editing the
instance without re-uploading an image does not affect the already-set
image (nor the auto-set width/height properties), but that test cannot
pass on trunk until a fix for #10121 has been checked in so I have not
included that test here yet.
--
Ticket URL: <http://code.djangoproject.com/ticket/10196#comment:7>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
