#10456: Canada localflavor improvements/fixes
-------------------------------------------------+--------------------------
Reporter: mmulley | Owner: nobody
Status: new | Milestone:
Component: django.contrib.localflavor | Version: SVN
Resolution: | Keywords: localflavor
ca
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------------------+--------------------------
Changes (by mmulley):
* needs_better_patch: 1 => 0
Comment:
To clarify, the second patch (labelled -oldabbrevs) doesn't duplicate
#10365 and does not include any backwards-incompatible changes to database
representations. Clearing needs_better_patch for now, unless/until there
are specific issues with that patch. Given that the first patch is
controversial, I'd suggest looking at the second patch (or rather the
mildly updated -compatible version), which at least accepts the correct
postal abbreviations as input, for the moment.
I would argue that the user-displayable data issue isn't entirely cut-and-
dried. For example, the documentation text for USStateField is "A form
field that validates input as a U.S. state name or abbreviation. It
normalizes the input to the standard two-letter postal service
abbreviation for the given state." Not some random non-displayable could-
be-an-integer internal representation, but "the standard two-letter postal
service abbreviation", implying that this is standardized and displayable
data. And it's certainly the case that, in the US and Canada, the postal
abbreviation is displayed to users just as if not more frequently than the
full state/province name.
But, yes, breaking database data is certainly bad. Anyone have a
suggestion on how to provide access to correct postal abbreviations (a
very, very common use case) without breaking compatibility or violating
design principles w/r/t user-displayable data?
(Uploading a slightly modified patch which adds a note about the postal
abbreviations to the documentation.)
--
Ticket URL: <http://code.djangoproject.com/ticket/10456#comment:3>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
