#8999: ModelAdmin.get_form and get_formset will overwrite self.exclude with a
kwargs exclude
-------------------------------------------+--------------------------------
          Reporter:  seanl                 |         Owner:  jkocherhans
            Status:  assigned              |     Milestone:             
         Component:  django.contrib.admin  |       Version:  1.0        
        Resolution:                        |      Keywords:             
             Stage:  Accepted              |     Has_patch:  1          
        Needs_docs:  0                     |   Needs_tests:  0          
Needs_better_patch:  0                     |  
-------------------------------------------+--------------------------------
Comment (by seanl):

 OK, that also makes sense as behaviour, but the current code looks like it
 intends to combine the values, but due to a subtlety kwargs takes
 precedence. (that the 'exclude' kwarg if present is left in the kwargs
 dict, and thus overrides when you come to defaults.update(kwargs) ). If
 the current behaviour is what is intended, then the whole 'excludes' line
 in the defaults dictionary literal should be removed, and the behaviour
 will be the same, but with the code reflecting the intent.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/8999#comment:6>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to