#10677: post_save_moderation breaks confirmation view
----------------------------------------------+-----------------------------
Reporter: nate-dja...@refried.org | Owner: nobody
Status: new | Milestone: 1.1
Component: django.contrib.comments | Version: 1.1-beta-1
Resolution: | Keywords: django comments
moderation
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
----------------------------------------------+-----------------------------
Comment (by nate-dja...@refried.org):
The patch looks a lot like what I did to fix the issue for my site. My
only problem with it is that I think the signal handler should return
False so the bad comment never touches the database. But that causes
post_comment() to return CommentPostBadRequest which does not have a
template when DEBUG == False. So if a comment_will_be_posted signal
handler returns False to refuse the comment, the user/client/spammer gets
a 400 response and a blank page. I think the 400 is right, but I don't
really like the blank page idea.
--
Ticket URL: <http://code.djangoproject.com/ticket/10677#comment:3>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
