#10768: Allow for Admin Actions to be applied to an empty QuerySet
----------------------------------------------+-----------------------------
Reporter: andreplebl...@gmail.com | Owner: nobody
Status: closed | Milestone:
Component: django.contrib.admin | Version: SVN
Resolution: wontfix | Keywords: actions
Stage: Unreviewed | Has_patch: 0
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
----------------------------------------------+-----------------------------
Comment (by andreplebl...@gmail.com):
at the risk of stepping on someone's toes, I'm going to push this issue
just a little bit further. The decision to NOT call the method when the
selection is empty seems unnecessary. Actions are there for an easy way
for developers to add custom functionality to the admin, it should be up
to the action itself to decide how to behave with an empty queryset, and
any action that is written to work with a queryset will effectively be a
no-op when given an empty queryset anyway. what if all I wanted to do was
add a message stating 'Please select at least one item to perform this
action on' when passed an empty queryset, I dont even have that option
because the admin app arbitrarily decides not to call my function, even
though it can't have any negative side-effects to simply pass it an empty
one. object tools may be the more 'correct' place for a developer to add
these types of functionality, but realistically, it's a LOT more work,
urls and views need to be constructed to handle it all, templates need to
be overridden, and it just feels hacky.
--
Ticket URL: <http://code.djangoproject.com/ticket/10768#comment:2>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
