#10842: Django 1.0.2 generates AttributeError with PostgreSql 8.4beta1
---------------------------------------------------+------------------------
Reporter: hgdeoro | Owner: nobody
Status: new | Milestone: 1.1
Component: Database layer (models, ORM) | Version: 1.0
Resolution: | Keywords: postgresql
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 1 |
---------------------------------------------------+------------------------
Comment (by mtredinnick):
The second approach is preferable, but I've been wondering if we can
encapsulate the version comparison a bit more. Into a function that tells
us whether the current version is before or after what we're looking for.
The motivation is that we really want to make sure that 8.4 beta1
evaluates as "before" 8.4.0 and 8.4-enterprise and so on. We're likely to
be tweaking things a bit over time and pure lexicographical comparison
isn't going to fix things completely. So let's make a function that is
passed the version we are comparing for as a triple (e.g. `(8, 4, 0)`) and
returns -1, 0, 1 if we are before, equal to or after that version.
Alternatively, it could always check for "before" (or "after" --
implementer's choice, but we don't need both versions) the version passed
in and return True or False. Then we can put function in one location and
everything else passes in the minimum version they want and operate
appropriately. The comparison version works better with the aggregate-
functionality test we have (excluding some 8.2.x versions), but the
boolean version could work with that as well.
Since 8.4beta1 is still not a final release, we've got time to fix this
properly and I'd like to do so. Appreciate the time you've put in on the
patches so far. It's getting closer. The second patch looks pretty good at
the moment.
--
Ticket URL: <http://code.djangoproject.com/ticket/10842#comment:4>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
