Author: jacob
Date: 2009-05-07 11:12:08 -0500 (Thu, 07 May 2009)
New Revision: 10692
Added:
django/trunk/tests/regressiontests/model_regress/tests.py
Modified:
django/trunk/django/db/models/fields/related.py
Log:
Fixed #10153: foreign key `gte` and `lte` lookups now work. Thanks, joelhooks
and adurdin.
Modified: django/trunk/django/db/models/fields/related.py
===================================================================
--- django/trunk/django/db/models/fields/related.py 2009-05-07 15:40:13 UTC
(rev 10691)
+++ django/trunk/django/db/models/fields/related.py 2009-05-07 16:12:08 UTC
(rev 10692)
@@ -155,7 +155,7 @@
# get_(next/prev)_by_date work; other lookups are not allowed since
that
# gets messy pretty quick. This is a good candidate for some
refactoring
# in the future.
- if lookup_type in ['exact', 'gt', 'lt']:
+ if lookup_type in ['exact', 'gt', 'lt', 'gte', 'lte']:
return [pk_trace(value)]
if lookup_type in ('range', 'in'):
return [pk_trace(v) for v in value]
Added: django/trunk/tests/regressiontests/model_regress/tests.py
===================================================================
--- django/trunk/tests/regressiontests/model_regress/tests.py
(rev 0)
+++ django/trunk/tests/regressiontests/model_regress/tests.py 2009-05-07
16:12:08 UTC (rev 10692)
@@ -0,0 +1,16 @@
+from models import Worker
+from django.test import TestCase
+
+class RelatedModelOrderedLookupTest(TestCase):
+ """
+ Regression test for #10153: foreign key __gte and __lte lookups.
+ """
+
+ # The bug is that the following queries would raise:
+ # "TypeError: Related Field has invalid lookup: gte"
+
+ def test_related_gte_lookup(self):
+ Worker.objects.filter(department__gte=0)
+
+ def test_related_lte_lookup(self):
+ Worker.objects.filter(department__lte=0)
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
