#9367: EmailMultiAlternatives does not properly handle attachments
---------------------------------------+------------------------------------
Reporter: loekje | Owner: lukeplant
Status: new | Milestone:
Component: django.core.mail | Version: 1.0
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
---------------------------------------+------------------------------------
Comment (by lukeplant):
It's still quite difficult to see what the patch does, due to the way diff
interprets things, but I've had a proper look. attach_file() doesn't
work correctly in the subclass because the subclass works by overriding
the value of multipart_subtype, which is used by the base class to build
the message. So the fundamental way !EmailMultiAlternatives works is
broken for normal attachments, hence the need for quite a big patch. But
it looks like a good patch.
I've added a test, I'll commit shortly. I'm taking it on trust that this
is necessary to fix behaviour in Outlook (the previous format of email
worked OK in my mail client, but Outlook's behaviour seems sensible as
loekje argues).
--
Ticket URL: <http://code.djangoproject.com/ticket/9367#comment:11>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
