#11320: Over aggressive join promotion with exclude()
---------------------------------------------------+------------------------
          Reporter:  Alex                          |         Owner:  nobody
            Status:  new                           |     Milestone:        
         Component:  Database layer (models, ORM)  |       Version:  SVN   
        Resolution:                                |      Keywords:        
             Stage:  Unreviewed                    |     Has_patch:  0     
        Needs_docs:  0                             |   Needs_tests:  0     
Needs_better_patch:  0                             |  
---------------------------------------------------+------------------------
Changes (by Alex):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Actually, upon further review my patch is even worse than the comment
 indicates.  The issue is that anything n an exlcude() gets unconditionally
 promoted to an OUTER JOIN, so my current patch would fail for something
 like {{{
 Event.objects.filter(venue__isnull=False).exlcude(venue__name='a') }}},
 because the exclude join promotion doesn't respect anything.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/11320#comment:1>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to